Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing security issue and null pointer dereference #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixing security issue and null pointer dereference #39

wants to merge 1 commit into from
+5 −2

Conversation

docfate111
Copy link

@docfate111 docfate111 commented Dec 28, 2020 •
edited
Loading

In client/main.cpp there was a buffer overflow(using scanf into 80 character buffer) and null pointer dereference(if -o was used without arguments).

➜  client git:(master) ✗ ./dialclient -o
[1]    3818535 segmentation fault  ./dialclient -o
➜  client git:(master) ✗ ./dialclient   
Sending mcast for discovery.  Please wait for 5 seconds for the response.
Found Multiple servers
0: Rescan and list DIAL servers
1: Server IP[143.110.160.145] UUID[uuid:deadbeef-dead-beef-dead-beefdeadbeef] FriendlyName[DIAL server sample] MacAddress[86:49:98:1c:2c:d3] WakeOnLanTimeout[10]
Enter server: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
*** stack smashing detected ***: terminated
[1]    3819851 abort      ./dialclient

Small changes to client/main.cpp should fix the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@docfate111